Being short is medically preferable, being tall is preferable for convenience and reach. Where humanity is at now, with a mix of both, is functionally preferable - the continuance of female preference may cause health issues in a few hundred years, though.

Short dudes have an easier time lifting more, there are height limits on many jobs and spinal issues get worse the farther you get above 6ft. Brtween 5'4" and 6'4 is about the optimal range.